You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fosdem schedule has a number of rooms with more than word, ie "K.1.105 (La Fontaine)" or "H.1302 (Depage)" and some of the commands were splitting the input args such that the second part of the name was being cut, meaning that the commands were unable to find the rooms.
This PR adds support for rooms with more than one word in them by changing how the args are parsed when the commands are run.
The other option for fixing this would be to strip all the rooms as they are parsed/stored - I considered that as well but this seemed faster - happy to change course if it's incorrect.
just as a note of interest, in previous years (or at least last year) these were 'slugified' into k1.1.05_la_fontaine etc or something like that and you'd refer to them by slug.
just as a note of interest, in previous years (or at least last year) these were 'slugified' into k1.1.05_la_fontaine etc or something like that and you'd refer to them by slug.
When the room is converted in an auditorium the name as given from the schedule is stored as id, and there is a separate field for the slug (slugified name). The function that looks up the input from the user in Verify and other commands, getAuditorium, looks up the auditorium by auditorium.id rather than auditorium.slug - I see the slug being used in the room aliases, though. So i think this change is still needed?
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fosdem schedule has a number of rooms with more than word, ie "K.1.105 (La Fontaine)" or "H.1302 (Depage)" and some of the commands were splitting the input args such that the second part of the name was being cut, meaning that the commands were unable to find the rooms.
This PR adds support for rooms with more than one word in them by changing how the args are parsed when the commands are run.
The other option for fixing this would be to strip all the rooms as they are parsed/stored - I considered that as well but this seemed faster - happy to change course if it's incorrect.